From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net 0/2] net/sched: fix NULL dereference in 'goto chain' control action Date: Sat, 07 Jul 2018 22:01:28 +0900 (KST) Message-ID: <20180707.220128.1910831515437830598.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: jiri@resnulli.us, amir@vadai.me, netdev@vger.kernel.org To: dcaratti@redhat.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:53164 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753965AbeGGNBh (ORCPT ); Sat, 7 Jul 2018 09:01:37 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Davide Caratti Date: Fri, 6 Jul 2018 21:01:04 +0200 > in a couple of TC actions (i.e. csum and tunnel_key), the control action > is stored together with the action-specific configuration data. > This avoids a race condition (see [1]), but it causes a crash when 'goto > chain' is used with the above actions. Since this race condition is > tolerated on the other TC actions (it's present even on actions where the > spinlock is still used), storing the control action in the common area > should be acceptable for tunnel_key and csum as well. > > [1] https://www.spinics.net/lists/netdev/msg472047.html Series applied and queued up for -stable, thanks Davide.