* [PATCH iproute2] tc: Fix the bug not to display prio and quantum options of htb
@ 2018-07-04 3:32 fumihiko kakuma
2018-07-04 5:01 ` Cong Wang
2018-07-07 16:59 ` Stephen Hemminger
0 siblings, 2 replies; 3+ messages in thread
From: fumihiko kakuma @ 2018-07-04 3:32 UTC (permalink / raw)
To: netdev; +Cc: fumihiko kakuma
A commandline like 'tc -d class show dev dev-name' does not
display value of prio and quantum option when we use htb qdisc.
This patch fixes the bug.
Signed-off-by: Fumihiko Kakuma <kakuma@valinux.co.jp>
---
tc/q_htb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tc/q_htb.c b/tc/q_htb.c
index 7d5f6ce..b93d31d 100644
--- a/tc/q_htb.c
+++ b/tc/q_htb.c
@@ -291,9 +291,9 @@ static int htb_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt)
if (RTA_PAYLOAD(tb[TCA_HTB_PARMS]) < sizeof(*hopt)) return -1;
if (!hopt->level) {
- print_int(PRINT_ANY, "prio", "prio ", (int)hopt->prio);
+ print_int(PRINT_ANY, "prio", "prio %d ", (int)hopt->prio);
if (show_details)
- print_int(PRINT_ANY, "quantum", "quantum ",
+ print_int(PRINT_ANY, "quantum", "quantum %d ",
(int)hopt->quantum);
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH iproute2] tc: Fix the bug not to display prio and quantum options of htb
2018-07-04 3:32 [PATCH iproute2] tc: Fix the bug not to display prio and quantum options of htb fumihiko kakuma
@ 2018-07-04 5:01 ` Cong Wang
2018-07-07 16:59 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Cong Wang @ 2018-07-04 5:01 UTC (permalink / raw)
To: kakuma; +Cc: Linux Kernel Network Developers
On Tue, Jul 3, 2018 at 8:33 PM fumihiko kakuma <kakuma@valinux.co.jp> wrote:
>
> A commandline like 'tc -d class show dev dev-name' does not
> display value of prio and quantum option when we use htb qdisc.
> This patch fixes the bug.
>
> Signed-off-by: Fumihiko Kakuma <kakuma@valinux.co.jp>
Good catch!
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH iproute2] tc: Fix the bug not to display prio and quantum options of htb
2018-07-04 3:32 [PATCH iproute2] tc: Fix the bug not to display prio and quantum options of htb fumihiko kakuma
2018-07-04 5:01 ` Cong Wang
@ 2018-07-07 16:59 ` Stephen Hemminger
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Hemminger @ 2018-07-07 16:59 UTC (permalink / raw)
To: fumihiko kakuma; +Cc: netdev
On Wed, 4 Jul 2018 12:32:33 +0900
fumihiko kakuma <kakuma@valinux.co.jp> wrote:
> A commandline like 'tc -d class show dev dev-name' does not
> display value of prio and quantum option when we use htb qdisc.
> This patch fixes the bug.
>
> Signed-off-by: Fumihiko Kakuma <kakuma@valinux.co.jp>
Applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-07 17:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-04 3:32 [PATCH iproute2] tc: Fix the bug not to display prio and quantum options of htb fumihiko kakuma
2018-07-04 5:01 ` Cong Wang
2018-07-07 16:59 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).