From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v3 net-next 0/3] fix use-after-free bugs in skb list processing Date: Mon, 09 Jul 2018 14:56:37 -0700 (PDT) Message-ID: <20180709.145637.1553377778182959664.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: ecree@solarflare.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:51956 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933090AbeGIV4k (ORCPT ); Mon, 9 Jul 2018 17:56:40 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Edward Cree Date: Mon, 9 Jul 2018 18:08:38 +0100 > A couple of bugs in skb list handling were spotted by Dan Carpenter, with > the help of Smatch; following up on them I found a couple more similar > cases. This series fixes them by changing the relevant loops to use the > dequeue-enqueue model (rather than in-place list modification). > > v3: fixed another similar bug in __netif_receive_skb_list_core(). > > v2: dropped patch #3 (new list.h helper), per DaveM's request. Applied, thanks Edward.