netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 net-next] net: Use __u32 in uapi net_stamp.h
@ 2018-07-09 23:20 Jesus Sanchez-Palencia
  2018-07-09 23:29 ` Eric Dumazet
  2018-07-09 23:31 ` David Miller
  0 siblings, 2 replies; 3+ messages in thread
From: Jesus Sanchez-Palencia @ 2018-07-09 23:20 UTC (permalink / raw)
  To: netdev; +Cc: davem, eric.dumazet, Jesus Sanchez-Palencia

We are not supposed to use u32 in uapi, so change the flags member of
struct sock_txtime from u32 to __u32 instead.

Fixes: 80b14dee2bea ("net: Add a new socket option for a future transmit time")
Reported-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>
---
 include/uapi/linux/net_tstamp.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/uapi/linux/net_tstamp.h b/include/uapi/linux/net_tstamp.h
index f8f4539f1135..97ff3c17ec4d 100644
--- a/include/uapi/linux/net_tstamp.h
+++ b/include/uapi/linux/net_tstamp.h
@@ -155,8 +155,8 @@ enum txtime_flags {
 };
 
 struct sock_txtime {
-	clockid_t       clockid;        /* reference clockid */
-	u32             flags;          /* flags defined by enum txtime_flags */
+	clockid_t	clockid;	/* reference clockid */
+	__u32		flags;		/* as defined by enum txtime_flags */
 };
 
 #endif /* _NET_TIMESTAMPING_H */
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 net-next] net: Use __u32 in uapi net_stamp.h
  2018-07-09 23:20 [PATCH v2 net-next] net: Use __u32 in uapi net_stamp.h Jesus Sanchez-Palencia
@ 2018-07-09 23:29 ` Eric Dumazet
  2018-07-09 23:31 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: Eric Dumazet @ 2018-07-09 23:29 UTC (permalink / raw)
  To: Jesus Sanchez-Palencia, netdev; +Cc: davem, eric.dumazet



On 07/09/2018 04:20 PM, Jesus Sanchez-Palencia wrote:
> We are not supposed to use u32 in uapi, so change the flags member of
> struct sock_txtime from u32 to __u32 instead.
> 
> Fixes: 80b14dee2bea ("net: Add a new socket option for a future transmit time")
> Reported-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>
> ---

Reviewed-by: Eric Dumazet <edumazet@google.com>

Thanks !

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 net-next] net: Use __u32 in uapi net_stamp.h
  2018-07-09 23:20 [PATCH v2 net-next] net: Use __u32 in uapi net_stamp.h Jesus Sanchez-Palencia
  2018-07-09 23:29 ` Eric Dumazet
@ 2018-07-09 23:31 ` David Miller
  1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-07-09 23:31 UTC (permalink / raw)
  To: jesus.sanchez-palencia; +Cc: netdev, eric.dumazet

From: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>
Date: Mon,  9 Jul 2018 16:20:56 -0700

> We are not supposed to use u32 in uapi, so change the flags member of
> struct sock_txtime from u32 to __u32 instead.
> 
> Fixes: 80b14dee2bea ("net: Add a new socket option for a future transmit time")
> Reported-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>

Applied.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-07-09 23:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-09 23:20 [PATCH v2 net-next] net: Use __u32 in uapi net_stamp.h Jesus Sanchez-Palencia
2018-07-09 23:29 ` Eric Dumazet
2018-07-09 23:31 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).