From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julian Wiedmann Subject: [PATCH net-next v2] tcp: remove SG-related comment in tcp_sendmsg() Date: Mon, 9 Jul 2018 09:45:14 +0200 Message-ID: <20180709074514.77218-1-jwi@linux.ibm.com> References: <5057f0d2-1d48-1665-8f9b-6123f7d3302c@gmail.com> Cc: Julian Wiedmann , To: David Miller , Eric Dumazet Return-path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:51650 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750974AbeGIHp1 (ORCPT ); Mon, 9 Jul 2018 03:45:27 -0400 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w697hoXK088329 for ; Mon, 9 Jul 2018 03:45:27 -0400 Received: from e06smtp01.uk.ibm.com (e06smtp01.uk.ibm.com [195.75.94.97]) by mx0a-001b2d01.pphosted.com with ESMTP id 2k3yg5m0f9-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 09 Jul 2018 03:45:27 -0400 Received: from localhost by e06smtp01.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 9 Jul 2018 08:45:25 +0100 In-Reply-To: <5057f0d2-1d48-1665-8f9b-6123f7d3302c@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: Since commit 74d4a8f8d378 ("tcp: remove sk_can_gso() use"), the code doesn't care whether the interface supports SG. Signed-off-by: Julian Wiedmann --- v2: remove the whole comment (Eric) net/ipv4/tcp.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index bf461fa77ed6..6ce14f8e3562 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -1275,9 +1275,6 @@ int tcp_sendmsg_locked(struct sock *sk, struct msghdr *msg, size_t size) int linear; new_segment: - /* Allocate new segment. If the interface is SG, - * allocate skb fitting to single page. - */ if (!sk_stream_memory_free(sk)) goto wait_for_sndbuf; -- 2.16.4