From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next] selftests: forwarding: mirror_lib: Tighten up
 VLAN capture
Date: Tue, 10 Jul 2018 22:58:29 -0700 (PDT)
Message-ID: <20180710.225829.143333520309033405.davem@davemloft.net>
References: <0fecbe018ff9a06a5f3686e3c4801b5005925019.1531072211.git.petrm@mellanox.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
        shuah@kernel.org
To: petrm@mellanox.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:59896 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726294AbeGKGBG (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 11 Jul 2018 02:01:06 -0400
In-Reply-To: <0fecbe018ff9a06a5f3686e3c4801b5005925019.1531072211.git.petrm@mellanox.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Petr Machata <petrm@mellanox.com>
Date: Sun, 08 Jul 2018 19:58:55 +0200

> The function do_test_span_vlan_dir_ips() is used for testing whether
> mirrored packets are VLAN-encapsulated. But since it only considers
> VLAN encapsulation, it may end up matching unmirrored ARP traffic as
> well. One consequence is a rare failure of mirror_gre_vlan_bridge_1q's
> test_gretap_untagged_egress. Decreasing ping cadence in mirror_test()
> makes the problem easily reproducible.
> 
> Therefore tighten up the match criterion to only count those 802.1q
> packets where the next header is IP.
> 
> Signed-off-by: Petr Machata <petrm@mellanox.com>

Applied.