From mboxrd@z Thu Jan 1 00:00:00 1970 From: Travis Brown Subject: [PATCH net-next] macvlan: Change status when lower device goes down Date: Tue, 10 Jul 2018 00:35:01 +0000 Message-ID: <20180710003501.13971-1-travisb@arista.com> Cc: Travis Brown , Suresh Krishnan To: netdev@vger.kernel.org Return-path: Received: from smtp.aristanetworks.com ([52.0.43.43]:49662 "EHLO usvae2-clmxp01.aristanetworks.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754588AbeGJAoz (ORCPT ); Mon, 9 Jul 2018 20:44:55 -0400 Sender: netdev-owner@vger.kernel.org List-ID: Today macvlan ignores the notification when a lower device goes administratively down, preventing the lack of connectivity from bubbling up. Processing NETDEV_DOWN results in a macvlan state of LOWERLAYERDOWN with NO-CARRIER which should be easy to interpret in userspace. 2: lower: mtu 1500 qdisc mq state DOWN mode DEFAULT group default qlen 1000 3: macvlan@lower: mtu 1500 qdisc noqueue state LOWERLAYERDOWN mode DEFAULT group default qlen 1000 Signed-off-by: Suresh Krishnan Signed-off-by: Travis Brown --- drivers/net/macvlan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index adde8fc45588..6dcd715a9370 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -1647,6 +1647,7 @@ static int macvlan_device_event(struct notifier_block *unused, switch (event) { case NETDEV_UP: + case NETDEV_DOWN: case NETDEV_CHANGE: list_for_each_entry(vlan, &port->vlans, list) netif_stacked_transfer_operstate(vlan->lowerdev, -- 2.16.1