From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gustavo A. R. Silva" Subject: [PATCH] net: sched: act_ife: fix memory leak Date: Tue, 10 Jul 2018 08:53:47 -0500 Message-ID: <20180710135347.GA15889@embeddedor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Vlad Buslov , "Gustavo A. R. Silva" To: Jamal Hadi Salim , Cong Wang , Jiri Pirko , "David S. Miller" Return-path: Received: from gateway34.websitewelcome.com ([192.185.148.200]:41443 "EHLO gateway34.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754260AbeGJOTX (ORCPT ); Tue, 10 Jul 2018 10:19:23 -0400 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway34.websitewelcome.com (Postfix) with ESMTP id E9349F3A17 for ; Tue, 10 Jul 2018 08:54:21 -0500 (CDT) Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: In case memory resources for *p* are allocated, release them before return. Addresses-Coverity-ID: 1471714 ("Resource leak") Fixes: 0190c1d452a9 ("net: sched: atomically check-allocate action") Signed-off-by: Gustavo A. R. Silva --- net/sched/act_ife.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/net/sched/act_ife.c b/net/sched/act_ife.c index a3eef00..3d6e265 100644 --- a/net/sched/act_ife.c +++ b/net/sched/act_ife.c @@ -485,8 +485,10 @@ static int tcf_ife_init(struct net *net, struct nlattr *nla, return -ENOMEM; err = tcf_idr_check_alloc(tn, &parm->index, a, bind); - if (err < 0) + if (err < 0) { + kfree(p); return err; + } exists = err; if (exists && bind) { kfree(p); -- 2.7.4