From mboxrd@z Thu Jan  1 00:00:00 1970
From: Russell King - ARM Linux <linux@armlinux.org.uk>
Subject: Re: [PATCH net-next 13/13] ARM: net: bpf: use double-word
 load/stores where available
Date: Tue, 10 Jul 2018 18:14:38 +0100
Message-ID: <20180710171438.GM17271@n2100.armlinux.org.uk>
References: <20180710123340.GK17271@n2100.armlinux.org.uk>
 <E1fcrtG-0005Vh-DK@rmk-PC.armlinux.org.uk>
 <CAOesGMio4JTzAPQ3Bkx8LxhkhJStzOGC6t2U8aC6m4TiBtaunQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Network Development <netdev@vger.kernel.org>,
        Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>,
        Daniel Borkmann <daniel@iogearbox.net>
To: Olof Johansson <olof@lixom.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from pandora.armlinux.org.uk ([78.32.30.218]:53914 "EHLO
        pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933268AbeGJROr (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 10 Jul 2018 13:14:47 -0400
Content-Disposition: inline
In-Reply-To: <CAOesGMio4JTzAPQ3Bkx8LxhkhJStzOGC6t2U8aC6m4TiBtaunQ@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, Jul 10, 2018 at 10:03:33AM -0700, Olof Johansson wrote:
> Hi Russell,
> > @@ -663,13 +679,27 @@ static inline void emit_a32_mov_r(const s8 dst, const s8 src,
> >  static inline void emit_a32_mov_r64(const bool is64, const s8 dst[],
> >                                   const s8 src[],
> >                                   struct jit_ctx *ctx) {
> > -       emit_a32_mov_r(dst_lo, src_lo, ctx);
> > -       if (is64) {
> > +       if (!is64) {
> > +               emit_a32_mov_r(dst_lo, src_lo, ctx);
> > +               /* Zero out high 4 bytes */
> > +               emit_a32_mov_i(dst_hi, 0, ctx);
> > +       } else if (__LINUX_ARM_ARCH__ < 6 &&
> > +                  ctx->cpu_architecture < CPU_ARCH_ARMv5) {
> >                 /* complete 8 byte move */
> > +               emit_a32_mov_r(dst_lo, src_lo, ctx);
> >                 emit_a32_mov_r(dst_hi, src_hi, ctx);
> 
> 
> Tiny nit: Looks like you compare for >= ARMv5TE above and <ARMv5 here.

Good catch, I'll fix it, and it gives me some satisfaction that
someone is reviewing this JIT code closely!  IMHO, JITs need a lot
of scrutiny.

> I'm not aware of any vanilla v5 implementations (all I can find are
> v5TE or <=v4T), so it doesn't seem like something actually causing
> problems. Mostly pointing it out for consistency's sake.

They're rare - I think the only one is an ARM1020 (ARMv5T) as opposed
to the ARM1020E (ARMv5TE).  Whether any are in the wild or not is
another matter.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up
According to speedtest.net: 13Mbps down 490kbps up