netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jianbol@mellanox.com
Cc: netdev@vger.kernel.org, jiri@resnulli.us,
	zahari.doychev@intel.com, jhs@mojatatu.com,
	xiyou.wangcong@gmail.com
Subject: Re: [PATCH net-next] net/sched: flower: Fix null pointer dereference when run tc vlan command
Date: Wed, 11 Jul 2018 22:48:31 -0700 (PDT)	[thread overview]
Message-ID: <20180711.224831.2104910551983464294.davem@davemloft.net> (raw)
In-Reply-To: <20180709022620.22168-1-jianbol@mellanox.com>

From: Jianbo Liu <jianbol@mellanox.com>
Date: Mon,  9 Jul 2018 02:26:20 +0000

> Zahari issued tc vlan command without setting vlan_ethtype, which will
> crash kernel. To avoid this, we must check tb[TCA_FLOWER_KEY_VLAN_ETH_TYPE]
> is not null before use it.
> Also we don't need to dump vlan_ethtype or cvlan_ethtype in this case.
> 
> Fixes: d64efd0926ba ('net/sched: flower: Add supprt for matching on QinQ vlan headers')
> Signed-off-by: Jianbo Liu <jianbol@mellanox.com>
> Reported-by: Zahari Doychev <zahari.doychev@intel.com>

Applied.

      reply	other threads:[~2018-07-12  5:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-09  2:26 [PATCH net-next] net/sched: flower: Fix null pointer dereference when run tc vlan command Jianbo Liu
2018-07-12  5:48 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180711.224831.2104910551983464294.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=jhs@mojatatu.com \
    --cc=jianbol@mellanox.com \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    --cc=zahari.doychev@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).