From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: inaky.perez-gonzalez@intel.com, linux-wimax@intel.com,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wimax/i2400m: remove redundant variables ack_status, bcf and protocol
Date: Wed, 11 Jul 2018 22:54:50 -0700 (PDT) [thread overview]
Message-ID: <20180711.225450.1331664103278085758.davem@davemloft.net> (raw)
In-Reply-To: <20180709122313.14483-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Mon, 9 Jul 2018 13:23:13 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Variables ack_status, bcf and protocol are being assigned but are
> never used hence they are redundant and can be removed.
>
> Also declare ack_type as unsigned int rather than unsigned to clean
> up a checkpatch warning.
>
> Cleans up clang warnings:
> warning: variable 'ack_status' set but not used [-Wunused-but-set-variable]
> warning: variable 'bcf' set but not used [-Wunused-but-set-variable]
> warning: variable 'protocol' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
This is simple enough that I'll just apply this directly, thanks
Colin.
prev parent reply other threads:[~2018-07-12 5:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 12:23 [PATCH] wimax/i2400m: remove redundant variables ack_status, bcf and protocol Colin King
2018-07-12 5:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180711.225450.1331664103278085758.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=colin.king@canonical.com \
--cc=inaky.perez-gonzalez@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wimax@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).