From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] wimax/i2400m: remove redundant variables ack_status, bcf and protocol Date: Wed, 11 Jul 2018 22:54:50 -0700 (PDT) Message-ID: <20180711.225450.1331664103278085758.davem@davemloft.net> References: <20180709122313.14483-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: inaky.perez-gonzalez@intel.com, linux-wimax@intel.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org To: colin.king@canonical.com Return-path: In-Reply-To: <20180709122313.14483-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Colin King Date: Mon, 9 Jul 2018 13:23:13 +0100 > From: Colin Ian King > > Variables ack_status, bcf and protocol are being assigned but are > never used hence they are redundant and can be removed. > > Also declare ack_type as unsigned int rather than unsigned to clean > up a checkpatch warning. > > Cleans up clang warnings: > warning: variable 'ack_status' set but not used [-Wunused-but-set-variable] > warning: variable 'bcf' set but not used [-Wunused-but-set-variable] > warning: variable 'protocol' set but not used [-Wunused-but-set-variable] > > Signed-off-by: Colin Ian King This is simple enough that I'll just apply this directly, thanks Colin.