From: David Miller <davem@davemloft.net>
To: gustavo@embeddedor.com
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: usb: hso: use swap macro in hso_kick_transmit
Date: Wed, 11 Jul 2018 22:58:21 -0700 (PDT) [thread overview]
Message-ID: <20180711.225821.1348569242901912298.davem@davemloft.net> (raw)
In-Reply-To: <20180709154048.GA32345@embeddedor.com>
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Mon, 9 Jul 2018 10:40:48 -0500
> @@ -1748,14 +1747,11 @@ static void hso_kick_transmit(struct hso_serial *serial)
> goto out;
>
> /* Switch pointers around to avoid memcpy */
> - temp = serial->tx_buffer;
> - serial->tx_buffer = serial->tx_data;
> - serial->tx_data = temp;
> + swap(serial->tx_buffer, serial->tx_data);
> serial->tx_data_count = serial->tx_buffer_count;
> serial->tx_buffer_count = 0;
>
> - /* If temp is set, it means we switched buffers */
> - if (temp && serial->write_data) {
> + if (serial->write_data) {
I think temp can be NULL here, you have to retain this check.
next prev parent reply other threads:[~2018-07-12 5:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 15:40 [PATCH] net: usb: hso: use swap macro in hso_kick_transmit Gustavo A. R. Silva
2018-07-12 5:58 ` David Miller [this message]
2018-07-12 19:27 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180711.225821.1348569242901912298.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).