From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] macvlan: Change status when lower device goes down Date: Wed, 11 Jul 2018 23:07:40 -0700 (PDT) Message-ID: <20180711.230740.435912925736299517.davem@davemloft.net> References: <20180710003501.13971-1-travisb@arista.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, skrishnan@arista.com To: travisb@arista.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:54726 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725995AbeGLGPl (ORCPT ); Thu, 12 Jul 2018 02:15:41 -0400 In-Reply-To: <20180710003501.13971-1-travisb@arista.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Travis Brown Date: Tue, 10 Jul 2018 00:35:01 +0000 > Today macvlan ignores the notification when a lower device goes > administratively down, preventing the lack of connectivity from > bubbling up. > > Processing NETDEV_DOWN results in a macvlan state of LOWERLAYERDOWN > with NO-CARRIER which should be easy to interpret in userspace. > > 2: lower: mtu 1500 qdisc mq state DOWN mode DEFAULT group default qlen 1000 > 3: macvlan@lower: mtu 1500 qdisc noqueue state LOWERLAYERDOWN mode DEFAULT group default qlen 1000 > > Signed-off-by: Suresh Krishnan > Signed-off-by: Travis Brown Seems reasonable, applied, thanks.