From: David Miller <davem@davemloft.net>
To: idosch@mellanox.com
Cc: netdev@vger.kernel.org, petrm@mellanox.com, jiri@mellanox.com,
mlxsw@mellanox.com
Subject: Re: [PATCH net-next 0/3] mlxsw: ERSPAN: Take LACP state into consideration
Date: Wed, 11 Jul 2018 23:10:32 -0700 (PDT) [thread overview]
Message-ID: <20180711.231032.1915465237915781710.davem@davemloft.net> (raw)
In-Reply-To: <20180710070259.24753-1-idosch@mellanox.com>
From: Ido Schimmel <idosch@mellanox.com>
Date: Tue, 10 Jul 2018 10:02:56 +0300
> Petr says:
>
> When offloading mirror-to-gretap, mlxsw needs to preroute the path that
> the encapsulated packet will take. That path may include a LAG device
> above a front panel port. So far, mlxsw resolved the path to the first
> up front panel slave of the LAG interface, but that only reflects
> administrative state of the port. It neglects to consider whether the
> port actually has a carrier, and what the LACP state is. This patch set
> aims to address these problems.
>
> Patch #1 publishes team_port_get_rcu().
>
> Then in patch #2, a new function is introduced,
> mlxsw_sp_port_dev_check(). That returns, for a given netdevice that is a
> slave of a LAG device, whether that device is "txable", i.e. whether the
> LAG master would send traffic through it. Since there's no good place to
> put LAG-wide helpers, introduce a new header include/net/lag.h.
>
> Finally in patch #3, fix the slave selection logic to take into
> consideration whether a given slave has a carrier and whether it is
> txable.
Series applied, thank you.
prev parent reply other threads:[~2018-07-12 6:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 7:02 [PATCH net-next 0/3] mlxsw: ERSPAN: Take LACP state into consideration Ido Schimmel
2018-07-10 7:02 ` [PATCH net-next 1/3] team: Publish team_port_get_rcu() Ido Schimmel
2018-07-10 7:02 ` [PATCH net-next 2/3] net: Add lag.h, net_lag_port_dev_txable() Ido Schimmel
2018-07-10 7:02 ` [PATCH net-next 3/3] mlxsw: spectrum_span: Change LAG lower selection Ido Schimmel
2018-07-12 6:10 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180711.231032.1915465237915781710.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).