From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 0/3] mlxsw: ERSPAN: Take LACP state into consideration Date: Wed, 11 Jul 2018 23:10:32 -0700 (PDT) Message-ID: <20180711.231032.1915465237915781710.davem@davemloft.net> References: <20180710070259.24753-1-idosch@mellanox.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, petrm@mellanox.com, jiri@mellanox.com, mlxsw@mellanox.com To: idosch@mellanox.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:54742 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725995AbeGLGSf (ORCPT ); Thu, 12 Jul 2018 02:18:35 -0400 In-Reply-To: <20180710070259.24753-1-idosch@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Ido Schimmel Date: Tue, 10 Jul 2018 10:02:56 +0300 > Petr says: > > When offloading mirror-to-gretap, mlxsw needs to preroute the path that > the encapsulated packet will take. That path may include a LAG device > above a front panel port. So far, mlxsw resolved the path to the first > up front panel slave of the LAG interface, but that only reflects > administrative state of the port. It neglects to consider whether the > port actually has a carrier, and what the LACP state is. This patch set > aims to address these problems. > > Patch #1 publishes team_port_get_rcu(). > > Then in patch #2, a new function is introduced, > mlxsw_sp_port_dev_check(). That returns, for a given netdevice that is a > slave of a LAG device, whether that device is "txable", i.e. whether the > LAG master would send traffic through it. Since there's no good place to > put LAG-wide helpers, introduce a new header include/net/lag.h. > > Finally in patch #3, fix the slave selection logic to take into > consideration whether a given slave has a carrier and whether it is > txable. Series applied, thank you.