From: David Miller <davem@davemloft.net>
To: rmk+kernel@armlinux.org.uk
Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net 2/2] sfp: fix module initialisation with netdev already up
Date: Wed, 11 Jul 2018 23:12:03 -0700 (PDT) [thread overview]
Message-ID: <20180711.231203.1203802251091215606.davem@davemloft.net> (raw)
In-Reply-To: <E1fcqSe-0004W1-8A@rmk-PC.armlinux.org.uk>
From: Russell King <rmk+kernel@armlinux.org.uk>
Date: Tue, 10 Jul 2018 12:05:36 +0100
> It was been observed that with a particular order of initialisation,
> the netdev can be up, but the SFP module still has its TX_DISABLE
> signal asserted. This occurs when the network device brought up before
> the SFP kernel module has been inserted by userspace.
>
> This occurs because sfp-bus layer does not hear about the change in
> network device state, and so assumes that it is still down. Set
> netdev->sfp when the upstream is registered to work around this problem.
>
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Applied.
prev parent reply other threads:[~2018-07-12 6:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-10 11:05 [PATCH net 2/2] sfp: fix module initialisation with netdev already up Russell King
2018-07-12 6:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180711.231203.1203802251091215606.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).