From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net 2/2] sfp: fix module initialisation with netdev already up Date: Wed, 11 Jul 2018 23:12:03 -0700 (PDT) Message-ID: <20180711.231203.1203802251091215606.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org To: rmk+kernel@armlinux.org.uk Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:54818 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726374AbeGLGUF (ORCPT ); Thu, 12 Jul 2018 02:20:05 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Russell King Date: Tue, 10 Jul 2018 12:05:36 +0100 > It was been observed that with a particular order of initialisation, > the netdev can be up, but the SFP module still has its TX_DISABLE > signal asserted. This occurs when the network device brought up before > the SFP kernel module has been inserted by userspace. > > This occurs because sfp-bus layer does not hear about the change in > network device state, and so assumes that it is still down. Set > netdev->sfp when the upstream is registered to work around this problem. > > Signed-off-by: Russell King Applied.