From: Stefano Brivio <sbrivio@redhat.com>
To: Li RongQing <lirongqing@baidu.com>
Cc: netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH] net: convert gro_count to bitmask
Date: Wed, 11 Jul 2018 12:51:33 +0200 [thread overview]
Message-ID: <20180711125133.60528540@epycfail> (raw)
In-Reply-To: <1531300553-21413-1-git-send-email-lirongqing@baidu.com>
On Wed, 11 Jul 2018 17:15:53 +0800
Li RongQing <lirongqing@baidu.com> wrote:
> @@ -5380,6 +5382,12 @@ static enum gro_result dev_gro_receive(struct napi_struct *napi, struct sk_buff
> if (grow > 0)
> gro_pull_from_frag0(skb, grow);
> ok:
> + if (napi->gro_hash[hash].count)
> + if (!test_bit(hash, &napi->gro_bitmask))
> + set_bit(hash, &napi->gro_bitmask);
> + else if (test_bit(hash, &napi->gro_bitmask))
> + clear_bit(hash, &napi->gro_bitmask);
This might not do what you want.
--
Stefano
next prev parent reply other threads:[~2018-07-11 10:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 9:15 [PATCH] net: convert gro_count to bitmask Li RongQing
2018-07-11 10:51 ` Stefano Brivio [this message]
2018-07-12 2:31 ` 答复: " Li,Rongqing
2018-07-12 9:48 ` Stefano Brivio
2018-07-11 11:32 ` Eric Dumazet
2018-07-12 2:31 ` 答复: " Li,Rongqing
2018-07-12 2:49 ` David Miller
2018-07-12 3:03 ` 答复: " Li,Rongqing
2018-07-12 3:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180711125133.60528540@epycfail \
--to=sbrivio@redhat.com \
--cc=edumazet@google.com \
--cc=lirongqing@baidu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).