From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH net-next v5 0/4] net: vhost: improve performance when enable busyloop Date: Wed, 11 Jul 2018 14:59:05 +0300 Message-ID: <20180711145421-mutt-send-email-mst@kernel.org> References: <1530678698-33427-1-git-send-email-xiangxia.m.yue@gmail.com> <934375dc-8925-c271-b2b0-b224ff5191c2@redhat.com> <4901593f-1d9e-2c47-b963-5fc1f48a1bfe@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Tonghao Zhang , makita.toshiaki@lab.ntt.co.jp, virtualization@lists.linux-foundation.org, Linux Kernel Network Developers To: Jason Wang Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35216 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726340AbeGKMDN (ORCPT ); Wed, 11 Jul 2018 08:03:13 -0400 Content-Disposition: inline In-Reply-To: <4901593f-1d9e-2c47-b963-5fc1f48a1bfe@redhat.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, Jul 11, 2018 at 01:12:59PM +0800, Jason Wang wrote: > > > On 2018年07月11日 11:49, Tonghao Zhang wrote: > > On Wed, Jul 11, 2018 at 10:56 AM Jason Wang wrote: > > > > > > > > > On 2018年07月04日 12:31, xiangxia.m.yue@gmail.com wrote: > > > > From: Tonghao Zhang > > > > > > > > This patches improve the guest receive and transmit performance. > > > > On the handle_tx side, we poll the sock receive queue at the same time. > > > > handle_rx do that in the same way. > > > > > > > > For more performance report, see patch 4. > > > > > > > > v4 -> v5: > > > > fix some issues > > > > > > > > v3 -> v4: > > > > fix some issues > > > > > > > > v2 -> v3: > > > > This patches are splited from previous big patch: > > > > http://patchwork.ozlabs.org/patch/934673/ > > > > > > > > Tonghao Zhang (4): > > > > vhost: lock the vqs one by one > > > > net: vhost: replace magic number of lock annotation > > > > net: vhost: factor out busy polling logic to vhost_net_busy_poll() > > > > net: vhost: add rx busy polling in tx path > > > > > > > > drivers/vhost/net.c | 108 ++++++++++++++++++++++++++++---------------------- > > > > drivers/vhost/vhost.c | 24 ++++------- > > > > 2 files changed, 67 insertions(+), 65 deletions(-) > > > > > > > Hi, any progress on the new version? > > > > > > I plan to send a new series of packed virtqueue support of vhost. If you > > > plan to send it soon, I can wait. Otherwise, I will send my series. > > I rebase the codes. and find there is no improvement anymore, the > > patches of makita may solve the problem. jason you may send your > > patches, and I will do some research on busypoll. > > I see. Maybe you can try some bi-directional traffic. > > Btw, lots of optimizations could be done for busy polling. E.g integrating > with host NAPI busy polling or a 100% busy polling vhost_net. You're welcome > to work or propose new ideas. > > Thanks It seems clear we do need adaptive polling. The difficulty with NAPI polling is it can't access guest memory easily. But maybe get_user_pages on the polled memory+NAPI polling can work. > > > > > Thanks