From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Saeed Mahameed <saeedm@mellanox.com>
Cc: Edward Cree <ecree@solarflare.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
brouer@redhat.com
Subject: Re: [net-next PATCH] net: ipv4: fix listify ip_rcv_finish in case of forwarding
Date: Wed, 11 Jul 2018 22:06:49 +0200 [thread overview]
Message-ID: <20180711220649.266b071a@redhat.com> (raw)
In-Reply-To: <7c5605ed2fe9505b982fde312d8416bd7fbbe6af.camel@mellanox.com>
On Wed, 11 Jul 2018 19:05:20 +0000
Saeed Mahameed <saeedm@mellanox.com> wrote:
> On Wed, 2018-07-11 at 17:01 +0200, Jesper Dangaard Brouer wrote:
> > Only driver sfc actually uses this, but I don't have this NIC, so I
> > tested this on mlx5, with my own changes to make it use
> > netif_receive_skb_list(),
> > but I'm not ready to upstream the mlx5 driver change yet.
>
>
> Thanks Jesper for sharing this, should we look forward to those patches
> or do you want us to implement them ?
Well, I would prefer you to implement those. I just did a quick
implementation (its trivially easy) so I have something to benchmark
with. The performance boost is quite impressive!
One reason I didn't "just" send a patch, is that Edward so-fare only
implemented netif_receive_skb_list() and not napi_gro_receive_list().
And your driver uses napi_gro_receive(). This sort-of disables GRO for
your driver, which is not a choice I can make. Interestingly I get
around the same netperf TCP_STREAM performance. I assume we can get
even better perf if we "listify" napi_gro_receive.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2018-07-11 20:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 15:01 [net-next PATCH] net: ipv4: fix listify ip_rcv_finish in case of forwarding Jesper Dangaard Brouer
2018-07-11 15:41 ` Edward Cree
2018-07-11 20:15 ` Jesper Dangaard Brouer
2018-07-11 19:05 ` Saeed Mahameed
2018-07-11 20:06 ` Jesper Dangaard Brouer [this message]
2018-07-12 20:10 ` Or Gerlitz
2018-07-13 11:08 ` Jesper Dangaard Brouer
2018-07-13 14:19 ` Edward Cree
2018-07-13 16:04 ` Jesper Dangaard Brouer
2018-07-13 18:14 ` Eric Dumazet
2018-07-30 14:38 ` Or Gerlitz
2018-07-12 23:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180711220649.266b071a@redhat.com \
--to=brouer@redhat.com \
--cc=ecree@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).