From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Dangaard Brouer Subject: Re: [net-next PATCH] net: ipv4: fix listify ip_rcv_finish in case of forwarding Date: Wed, 11 Jul 2018 22:06:49 +0200 Message-ID: <20180711220649.266b071a@redhat.com> References: <153132125549.13161.16380200872856218805.stgit@firesoul> <7c5605ed2fe9505b982fde312d8416bd7fbbe6af.camel@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Edward Cree , "netdev@vger.kernel.org" , brouer@redhat.com To: Saeed Mahameed Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:57130 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1733070AbeGKUMv (ORCPT ); Wed, 11 Jul 2018 16:12:51 -0400 In-Reply-To: <7c5605ed2fe9505b982fde312d8416bd7fbbe6af.camel@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 11 Jul 2018 19:05:20 +0000 Saeed Mahameed wrote: > On Wed, 2018-07-11 at 17:01 +0200, Jesper Dangaard Brouer wrote: > > Only driver sfc actually uses this, but I don't have this NIC, so I > > tested this on mlx5, with my own changes to make it use > > netif_receive_skb_list(), > > but I'm not ready to upstream the mlx5 driver change yet. > > > Thanks Jesper for sharing this, should we look forward to those patches > or do you want us to implement them ? Well, I would prefer you to implement those. I just did a quick implementation (its trivially easy) so I have something to benchmark with. The performance boost is quite impressive! One reason I didn't "just" send a patch, is that Edward so-fare only implemented netif_receive_skb_list() and not napi_gro_receive_list(). And your driver uses napi_gro_receive(). This sort-of disables GRO for your driver, which is not a choice I can make. Interestingly I get around the same netperf TCP_STREAM performance. I assume we can get even better perf if we "listify" napi_gro_receive. -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer