From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net: systemport: Fix CRC forwarding check for SYSTEMPORT Lite Date: Thu, 12 Jul 2018 14:47:58 -0700 (PDT) Message-ID: <20180712.144758.1033301223663799674.davem@davemloft.net> References: <20180711094758.1670-1-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: f.fainelli@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:43252 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726520AbeGLV71 (ORCPT ); Thu, 12 Jul 2018 17:59:27 -0400 In-Reply-To: <20180711094758.1670-1-f.fainelli@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Florian Fainelli Date: Wed, 11 Jul 2018 02:47:58 -0700 > SYSTEMPORT Lite reversed the logic compared to SYSTEMPORT, the > GIB_FCS_STRIP bit is set when the Ethernet FCS is stripped, and that bit > is not set by default. Fix the logic such that we properly check whether > that bit is set or not and we don't forward an extra 4 bytes to the > network stack. > > Fixes: 44a4524c54af ("net: systemport: Add support for SYSTEMPORT Lite") > Signed-off-by: Florian Fainelli Applied.