From: David Miller <davem@davemloft.net>
To: dcaratti@redhat.com
Cc: xiyou.wangcong@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 0/2] net/sched: act_skbedit: lockless data path
Date: Thu, 12 Jul 2018 14:54:27 -0700 (PDT) [thread overview]
Message-ID: <20180712.145427.1226587891063751899.davem@davemloft.net> (raw)
In-Reply-To: <cover.1531315251.git.dcaratti@redhat.com>
From: Davide Caratti <dcaratti@redhat.com>
Date: Wed, 11 Jul 2018 16:04:48 +0200
> the data path of act_skbedit can be faster if we avoid using spinlocks:
> - patch 1 converts act_skbedit statistics to use per-cpu counters
> - patch 2 lets act_skbedit use RCU to read/update its configuration
>
> test procedure (using pktgen from https://github.com/netoptimizer):
>
> # ip link add name eth1 type dummy
> # ip link set dev eth1 up
> # tc qdisc add dev eth1 clsact
> # tc filter add dev eth1 egress matchall action skbedit priority c1a0:c1a0
> # for c in 1 2 4 ; do
> > ./pktgen_bench_xmit_mode_queue_xmit.sh -v -s 64 -t $c -n 5000000 -i eth1
> > done
>
> test results (avg. pps/thread)
>
> $c | before patch | after patch | improvement
> ----+--------------+--------------+------------
> 1 | 3917464 ± 3% | 4000458 ± 3% | irrelevant
> 2 | 3455367 ± 4% | 3953076 ± 1% | +14%
> 4 | 2496594 ± 2% | 3801123 ± 3% | +52%
>
> v2: rebased on latest net-next
Series applied, thank you.
prev parent reply other threads:[~2018-07-12 22:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 14:04 [PATCH net-next v2 0/2] net/sched: act_skbedit: lockless data path Davide Caratti
2018-07-11 14:04 ` [PATCH net-next v2 1/2] net/sched: skbedit: use per-cpu counters Davide Caratti
2018-07-11 14:04 ` [PATCH net-next v2 2/2] net/sched: act_skbedit: don't use spinlock in the data path Davide Caratti
2018-07-12 21:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180712.145427.1226587891063751899.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).