From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next v2 0/2] net/sched: act_skbedit: lockless data path Date: Thu, 12 Jul 2018 14:54:27 -0700 (PDT) Message-ID: <20180712.145427.1226587891063751899.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Cc: xiyou.wangcong@gmail.com, netdev@vger.kernel.org To: dcaratti@redhat.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:43464 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726594AbeGLWF6 (ORCPT ); Thu, 12 Jul 2018 18:05:58 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Davide Caratti Date: Wed, 11 Jul 2018 16:04:48 +0200 > the data path of act_skbedit can be faster if we avoid using spinlocks: > - patch 1 converts act_skbedit statistics to use per-cpu counters > - patch 2 lets act_skbedit use RCU to read/update its configuration > > test procedure (using pktgen from https://github.com/netoptimizer): > > # ip link add name eth1 type dummy > # ip link set dev eth1 up > # tc qdisc add dev eth1 clsact > # tc filter add dev eth1 egress matchall action skbedit priority c1a0:c1a0 > # for c in 1 2 4 ; do > > ./pktgen_bench_xmit_mode_queue_xmit.sh -v -s 64 -t $c -n 5000000 -i eth1 > > done > > test results (avg. pps/thread) > > $c | before patch | after patch | improvement > ----+--------------+--------------+------------ > 1 | 3917464 ± 3% | 4000458 ± 3% | irrelevant > 2 | 3455367 ± 4% | 3953076 ± 1% | +14% > 4 | 2496594 ± 2% | 3801123 ± 3% | +52% > > v2: rebased on latest net-next Series applied, thank you.