From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Benc Subject: Re: [PATCH net] nsh: set mac len based on inner packet Date: Thu, 12 Jul 2018 09:28:05 +0200 Message-ID: <20180712092805.19bbe4c2@redhat.com> References: <20180711160046.198091-1-willemdebruijn.kernel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net, Willem de Bruijn To: Willem de Bruijn Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35948 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725995AbeGLHgZ (ORCPT ); Thu, 12 Jul 2018 03:36:25 -0400 In-Reply-To: <20180711160046.198091-1-willemdebruijn.kernel@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 11 Jul 2018 12:00:44 -0400, Willem de Bruijn wrote: > From: Willem de Bruijn > > When pulling the NSH header in nsh_gso_segment, set the mac length > based on the encapsulated packet type. > > skb_reset_mac_len computes an offset to the network header, which > here still points to the outer packet: > > > skb_reset_network_header(skb); > > [...] > > __skb_pull(skb, nsh_len); > > skb_reset_mac_header(skb); // now mac hdr starts nsh_len == 8B after net hdr > > skb_reset_mac_len(skb); // mac len = net hdr - mac hdr == (u16) -8 == 65528 > > [..] > > skb_mac_gso_segment(skb, ..) > > Link: http://lkml.kernel.org/r/CAF=yD-KeAcTSOn4AxirAxL8m7QAS8GBBe1w09eziYwvPbbUeYA@mail.gmail.com > Reported-by: syzbot+7b9ed9872dab8c32305d@syzkaller.appspotmail.com > Fixes: c411ed854584 ("nsh: add GSO support") > Signed-off-by: Willem de Bruijn Acked-by: Jiri Benc