From: Steffen Klassert <steffen.klassert@secunet.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Florian Westphal <fw@strlen.de>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] [RESEND, net-next] xfrm: use time64_t for in-kernel timestamps
Date: Thu, 12 Jul 2018 21:10:30 +0200 [thread overview]
Message-ID: <20180712191030.4chaji3vswtnltdc@gauss3.secunet.de> (raw)
In-Reply-To: <20180711101941.4039411-1-arnd@arndb.de>
On Wed, Jul 11, 2018 at 12:19:13PM +0200, Arnd Bergmann wrote:
> The lifetime managment uses '__u64' timestamps on the user space
> interface, but 'unsigned long' for reading the current time in the kernel
> with get_seconds().
>
> While this is probably safe beyond y2038, it will still overflow in 2106,
> and the get_seconds() call is deprecated because fo that.
>
> This changes the xfrm time handling to use time64_t consistently, along
> with reading the time using the safer ktime_get_real_seconds(). It still
> suffers from problems that can happen from a concurrent settimeofday()
> call or (to a lesser degree) a leap second update, but since the time
> stamps are part of the user API, there is nothing we can do to prevent
> that.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to the ipsec-next tree, thanks a lot!
prev parent reply other threads:[~2018-07-12 19:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 10:19 [PATCH 1/2] [RESEND, net-next] xfrm: use time64_t for in-kernel timestamps Arnd Bergmann
2018-07-11 10:19 ` [PATCH 2/2] [RESEND, net-next] ipv6: xfrm: use 64-bit timestamps Arnd Bergmann
2018-07-12 19:11 ` Steffen Klassert
2018-07-12 19:10 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180712191030.4chaji3vswtnltdc@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox