From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Qiaobin Fu <qiaobinf@bu.edu>
Cc: dsahern@gmail.com, stephen@networkplumber.org,
davem@davemloft.net, netdev@vger.kernel.org, jhs@mojatatu.com,
michel@digirati.com.br, xiyou.wangcong@gmail.com,
dcaratti@redhat.com
Subject: Re: [PATCH iproute2-next v2] net:sched: add action inheritdsfield to skbedit
Date: Thu, 12 Jul 2018 17:50:59 -0300 [thread overview]
Message-ID: <20180712205059.GH8880@localhost.localdomain> (raw)
In-Reply-To: <20180712160926.163317-1-qiaobinf@bu.edu>
On Thu, Jul 12, 2018 at 12:09:26PM -0400, Qiaobin Fu wrote:
> @@ -156,6 +162,9 @@ parse_skbedit(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
> if (flags & SKBEDIT_F_PTYPE)
> addattr_l(n, MAX_MSG, TCA_SKBEDIT_PTYPE,
> &ptype, sizeof(ptype));
> + if (pure_flags != 0)
> + addattr_l(n, MAX_MSG, TCA_SKBEDIT_FLAGS,
> + &pure_flags, sizeof(pure_flags));
It is missing 2 spaces ^--- here, to make the indentation right. (as
in the block above)
Marcelo
next prev parent reply other threads:[~2018-07-12 21:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 16:09 [PATCH iproute2-next v2] net:sched: add action inheritdsfield to skbedit Qiaobin Fu
2018-07-12 20:50 ` Marcelo Ricardo Leitner [this message]
2018-07-12 22:05 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180712205059.GH8880@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=davem@davemloft.net \
--cc=dcaratti@redhat.com \
--cc=dsahern@gmail.com \
--cc=jhs@mojatatu.com \
--cc=michel@digirati.com.br \
--cc=netdev@vger.kernel.org \
--cc=qiaobinf@bu.edu \
--cc=stephen@networkplumber.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).