From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Subject: Re: [PATCH iproute2-next v2] net:sched: add action inheritdsfield to
 skbedit
Date: Thu, 12 Jul 2018 17:50:59 -0300
Message-ID: <20180712205059.GH8880@localhost.localdomain>
References: <20180712160926.163317-1-qiaobinf@bu.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dsahern@gmail.com, stephen@networkplumber.org, davem@davemloft.net,
        netdev@vger.kernel.org, jhs@mojatatu.com, michel@digirati.com.br,
        xiyou.wangcong@gmail.com, dcaratti@redhat.com
To: Qiaobin Fu <qiaobinf@bu.edu>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-qt0-f182.google.com ([209.85.216.182]:45656 "EHLO
        mail-qt0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1732720AbeGLVCS (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 12 Jul 2018 17:02:18 -0400
Received: by mail-qt0-f182.google.com with SMTP id y5-v6so25340657qti.12
        for <netdev@vger.kernel.org>; Thu, 12 Jul 2018 13:51:02 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20180712160926.163317-1-qiaobinf@bu.edu>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Thu, Jul 12, 2018 at 12:09:26PM -0400, Qiaobin Fu wrote:
> @@ -156,6 +162,9 @@ parse_skbedit(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
>  	if (flags & SKBEDIT_F_PTYPE)
>  		addattr_l(n, MAX_MSG, TCA_SKBEDIT_PTYPE,
>  			  &ptype, sizeof(ptype));
> +	if (pure_flags != 0)
> +		addattr_l(n, MAX_MSG, TCA_SKBEDIT_FLAGS,
> +			&pure_flags, sizeof(pure_flags));

It is missing 2 spaces  ^--- here, to make the indentation right. (as
in the block above)

  Marcelo