From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH v4 net-next 19/19] net/mlx5e: Kconfig, mutually exclude
 compilation of TLS and IPsec accel
Date: Fri, 13 Jul 2018 14:44:40 -0700 (PDT)
Message-ID: <20180713.144440.1556859491192856560.davem@davemloft.net>
References: <1531423557-30926-20-git-send-email-borisp@mellanox.com>
        <20180712.174400.1595251769011299658.davem@davemloft.net>
        <4c27cdb3-bb8f-02b7-477e-e82d113b2b6d@mellanox.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, davejwatson@fb.com, aviadye@mellanox.com,
        saeedm@mellanox.com
To: borisp@mellanox.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([23.128.96.9]:36882 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725908AbeGMWBH (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 13 Jul 2018 18:01:07 -0400
In-Reply-To: <4c27cdb3-bb8f-02b7-477e-e82d113b2b6d@mellanox.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Boris Pismenny <borisp@mellanox.com>
Date: Fri, 13 Jul 2018 16:03:01 -0400

> We currently have no devices that support both TLS and IPsec using the
> accel framework

I read this the first time, and this is not what I am objecting to.

The compile time limitation is the problem, not the run time
limitation.

> Looking a bit more carefully at the code. We don't need this patch,
> because we still don't have a deviceID for both TLS and IPsec, so the
> problematic flow cannot happen. So we've just been over zealous
> here. I'll remove this patch and send a v5.

Ok, thanks.