From: David Miller <davem@davemloft.net>
To: xiyou.wangcong@gmail.com
Cc: vladbu@mellanox.com, netdev@vger.kernel.org, jhs@mojatatu.com,
jiri@resnulli.us, ast@kernel.org, daniel@iogearbox.net,
kliteyn@mellanox.com, jiri@mellanox.com
Subject: Re: [PATCH net-next v6 01/11] net: sched: use rcu for action cookie update
Date: Fri, 13 Jul 2018 15:11:10 -0700 (PDT) [thread overview]
Message-ID: <20180713.151110.334103662560259751.davem@davemloft.net> (raw)
In-Reply-To: <CAM_iQpWGofJ_wVuoP8+hHYi5=LM8+3dC-sCMBaY8KEjwrMnNLw@mail.gmail.com>
From: Cong Wang <xiyou.wangcong@gmail.com>
Date: Fri, 13 Jul 2018 14:51:15 -0700
> Can we at least agree you have no justification for this change in
> this changelog?
He stated that he wishes to make this subsystem more lockless, and he
cannot do that without making the action cookie handling use RCU.
I agree with the stated goal, and the necessity of this kind of change.
Therefore I applied the patch.
I really don't see what the problem is.
I also gave a couple days for this patch set to get reviewed. If you
have a problem, please respond to the patch posting. When I see nobody
is reviewing, that is when I step in and make my own judgment.
So when you want your objection to be heard, please do so in a timely
manner. That helps all of us.
Thank you.
next prev parent reply other threads:[~2018-07-13 22:27 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 14:24 [PATCH net-next v6 00/11] Modify action API for implementing lockless actions Vlad Buslov
2018-07-05 14:24 ` [PATCH net-next v6 01/11] net: sched: use rcu for action cookie update Vlad Buslov
2018-07-13 3:52 ` Cong Wang
2018-07-13 13:30 ` Vlad Buslov
2018-07-13 21:51 ` Cong Wang
2018-07-13 22:11 ` David Miller [this message]
2018-07-14 0:14 ` Cong Wang
2018-07-16 8:31 ` Vlad Buslov
2018-07-17 20:46 ` Cong Wang
2018-07-05 14:24 ` [PATCH net-next v6 02/11] net: sched: change type of reference and bind counters Vlad Buslov
2018-07-05 14:24 ` [PATCH net-next v6 03/11] net: sched: implement unlocked action init API Vlad Buslov
2018-07-05 14:24 ` [PATCH net-next v6 04/11] net: sched: always take reference to action Vlad Buslov
2018-07-05 14:24 ` [PATCH net-next v6 05/11] net: sched: implement action API that deletes action by index Vlad Buslov
2018-07-05 14:24 ` [PATCH net-next v6 06/11] net: sched: add 'delete' function to action ops Vlad Buslov
2018-08-09 19:38 ` Cong Wang
2018-08-10 9:41 ` Vlad Buslov
2018-07-05 14:24 ` [PATCH net-next v6 07/11] net: sched: implement reference counted action release Vlad Buslov
2018-07-05 14:24 ` [PATCH net-next v6 08/11] net: sched: don't release reference on action overwrite Vlad Buslov
2018-08-13 23:00 ` Cong Wang
2018-08-14 17:23 ` Vlad Buslov
2018-07-05 14:24 ` [PATCH net-next v6 09/11] net: sched: use reference counting action init Vlad Buslov
2018-07-05 14:24 ` [PATCH net-next v6 10/11] net: sched: atomically check-allocate action Vlad Buslov
2018-08-08 1:20 ` Cong Wang
2018-08-08 12:06 ` Vlad Buslov
2018-08-09 23:43 ` Cong Wang
2018-08-10 10:29 ` Vlad Buslov
2018-08-10 21:45 ` Cong Wang
2018-08-13 7:55 ` Vlad Buslov
2018-07-05 14:24 ` [PATCH net-next v6 11/11] net: sched: change action API to use array of pointers to actions Vlad Buslov
2018-08-07 23:26 ` Cong Wang
2018-08-08 11:41 ` Vlad Buslov
2018-08-08 18:29 ` Cong Wang
2018-08-09 7:03 ` Vlad Buslov
2018-07-07 11:41 ` [PATCH net-next v6 00/11] Modify action API for implementing lockless actions David Miller
2018-07-08 3:43 ` David Miller
2018-07-13 3:54 ` Cong Wang
2018-07-13 13:40 ` Vlad Buslov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180713.151110.334103662560259751.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=jhs@mojatatu.com \
--cc=jiri@mellanox.com \
--cc=jiri@resnulli.us \
--cc=kliteyn@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=vladbu@mellanox.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).