* [PATCH] liquidio: Use %pad printk format for dma_addr_t values
@ 2018-07-12 20:36 Helge Deller
2018-07-13 0:06 ` Felix Manlunas
2018-07-16 20:37 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Helge Deller @ 2018-07-12 20:36 UTC (permalink / raw)
To: Derek Chickles, Satanand Burla, Felix Manlunas, Raghu Vatsavayi,
netdev
Cc: linux-parisc
Use the existing %pad printk format to print dma_addr_t values.
This avoids the following warnings when compiling on the parisc platform:
warning: format '%llx' expects argument of type 'long long unsigned int', but argument 2 has type 'dma_addr_t {aka unsigned int}' [-Wformat=]
Signed-off-by: Helge Deller <deller@gmx.de>
diff --git a/drivers/net/ethernet/cavium/liquidio/request_manager.c b/drivers/net/ethernet/cavium/liquidio/request_manager.c
index 1f2e75da28f8..d5d9e47daa4b 100644
--- a/drivers/net/ethernet/cavium/liquidio/request_manager.c
+++ b/drivers/net/ethernet/cavium/liquidio/request_manager.c
@@ -110,8 +110,8 @@ int octeon_init_instr_queue(struct octeon_device *oct,
memset(iq->request_list, 0, sizeof(*iq->request_list) * num_descs);
- dev_dbg(&oct->pci_dev->dev, "IQ[%d]: base: %p basedma: %llx count: %d\n",
- iq_no, iq->base_addr, iq->base_addr_dma, iq->max_count);
+ dev_dbg(&oct->pci_dev->dev, "IQ[%d]: base: %p basedma: %pad count: %d\n",
+ iq_no, iq->base_addr, &iq->base_addr_dma, iq->max_count);
iq->txpciq.u64 = txpciq.u64;
iq->fill_threshold = (u32)conf->db_min;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] liquidio: Use %pad printk format for dma_addr_t values
2018-07-12 20:36 [PATCH] liquidio: Use %pad printk format for dma_addr_t values Helge Deller
@ 2018-07-13 0:06 ` Felix Manlunas
2018-07-16 20:37 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Felix Manlunas @ 2018-07-13 0:06 UTC (permalink / raw)
To: Helge Deller
Cc: Derek Chickles, Satanand Burla, Felix Manlunas, Raghu Vatsavayi,
netdev, linux-parisc
On Thu, Jul 12, 2018 at 10:36:29PM +0200, Helge Deller wrote:
> Use the existing %pad printk format to print dma_addr_t values.
> This avoids the following warnings when compiling on the parisc platform:
>
> warning: format '%llx' expects argument of type 'long long unsigned int', but argument 2 has type 'dma_addr_t {aka unsigned int}' [-Wformat=]
>
> Signed-off-by: Helge Deller <deller@gmx.de>
>
> diff --git a/drivers/net/ethernet/cavium/liquidio/request_manager.c b/drivers/net/ethernet/cavium/liquidio/request_manager.c
> index 1f2e75da28f8..d5d9e47daa4b 100644
> --- a/drivers/net/ethernet/cavium/liquidio/request_manager.c
> +++ b/drivers/net/ethernet/cavium/liquidio/request_manager.c
> @@ -110,8 +110,8 @@ int octeon_init_instr_queue(struct octeon_device *oct,
>
> memset(iq->request_list, 0, sizeof(*iq->request_list) * num_descs);
>
> - dev_dbg(&oct->pci_dev->dev, "IQ[%d]: base: %p basedma: %llx count: %d\n",
> - iq_no, iq->base_addr, iq->base_addr_dma, iq->max_count);
> + dev_dbg(&oct->pci_dev->dev, "IQ[%d]: base: %p basedma: %pad count: %d\n",
> + iq_no, iq->base_addr, &iq->base_addr_dma, iq->max_count);
>
> iq->txpciq.u64 = txpciq.u64;
> iq->fill_threshold = (u32)conf->db_min;
Acked-by: Felix Manlunas <felix.manlunas@cavium.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] liquidio: Use %pad printk format for dma_addr_t values
2018-07-12 20:36 [PATCH] liquidio: Use %pad printk format for dma_addr_t values Helge Deller
2018-07-13 0:06 ` Felix Manlunas
@ 2018-07-16 20:37 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-07-16 20:37 UTC (permalink / raw)
To: deller
Cc: derek.chickles, satananda.burla, felix.manlunas, raghu.vatsavayi,
netdev, linux-parisc
From: Helge Deller <deller@gmx.de>
Date: Thu, 12 Jul 2018 22:36:29 +0200
> Use the existing %pad printk format to print dma_addr_t values.
> This avoids the following warnings when compiling on the parisc platform:
>
> warning: format '%llx' expects argument of type 'long long unsigned int', but argument 2 has type 'dma_addr_t {aka unsigned int}' [-Wformat=]
>
> Signed-off-by: Helge Deller <deller@gmx.de>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-16 21:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-12 20:36 [PATCH] liquidio: Use %pad printk format for dma_addr_t values Helge Deller
2018-07-13 0:06 ` Felix Manlunas
2018-07-16 20:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).