From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Subject: Re: [PATCH iproute2-next 0/9] TC more JSON support
Date: Fri, 13 Jul 2018 14:29:42 -0700
Message-ID: <20180713142942.49d24264@cakuba.lan>
References: <20180709194856.18922-1-stephen@networkplumber.org>
        <9ad5c235-8c66-4a62-0517-af4ae6bdddac@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Stephen Hemminger <stephen@networkplumber.org>,
        netdev@vger.kernel.org, Stephen Hemminger <sthemmin@microsoft.com>,
        Jiri Pirko <jiri@mellanox.com>,
        Cong Wang <xiyou.wangcong@gmail.com>,
        Jamal Hadi Salim <jhs@mojatatu.com>
To: David Ahern <dsahern@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-qk0-f196.google.com ([209.85.220.196]:36272 "EHLO
        mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725908AbeGMVqL (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 13 Jul 2018 17:46:11 -0400
Received: by mail-qk0-f196.google.com with SMTP id a132-v6so17922316qkg.3
        for <netdev@vger.kernel.org>; Fri, 13 Jul 2018 14:29:47 -0700 (PDT)
In-Reply-To: <9ad5c235-8c66-4a62-0517-af4ae6bdddac@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, 13 Jul 2018 16:48:28 -0400, David Ahern wrote:
> On 7/9/18 3:48 PM, Stephen Hemminger wrote:
> > From: Stephen Hemminger <sthemmin@microsoft.com>
> > 
> > Update core of TC command and library to do more JSON.
> > Most of this patch set is about getting tc utility functions
> > to be more friendly to the json_print infrastructure.
> > 
> > Stephen Hemminger (9):
> >   tc: use JSON in error handling
> >   tc: use const char in util
> >   tc: convert stats print to json
> >   tc/cbq: use sprint_rate
> >   tc/util: remove print_rate
> >   tc/util: remove unused print_size
> >   tc/util: remove unused print_time
> >   tc/util: add print helpers for JSON
> >   tc/sfq: add json support
> > 
> >  tc/q_cbq.c   | 15 ++++-----
> >  tc/q_sfq.c   | 65 +++++++++++++++++++++---------------
> >  tc/tc.c      | 19 ++++++-----
> >  tc/tc_util.c | 94 +++++++++++++++++++++++++++-------------------------
> >  tc/tc_util.h | 11 +++---
> >  5 files changed, 109 insertions(+), 95 deletions(-)
> >   
> 
> I'd prefer some tc folks to take a look at the json output and verify
> everything is good.
> 
> Jamal, Jiri, Jakub, Cong, others?
> 
> There is a second set with 30 patches as well.

AFAIK the 31 patches supersede this set?  I only have tests that use
JSON for MQ and RED qdiscs, and those work fine with the v2 applied!