From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [PATCH 2/2] samples/bpf: test_cgrp2_sock2: fix an off by one Date: Fri, 13 Jul 2018 18:05:37 +0300 Message-ID: <20180713150301.gdvfu2ejlzlnglii@kili.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Daniel Borkmann , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: Alexei Starovoitov Return-path: Received: from aserp2130.oracle.com ([141.146.126.79]:43984 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729643AbeGMPVK (ORCPT ); Fri, 13 Jul 2018 11:21:10 -0400 Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: "prog_cnt" is the number of elements which are filled out in prog_fd[] so the test should be >= instead of >. Signed-off-by: Dan Carpenter diff --git a/samples/bpf/test_cgrp2_sock2.c b/samples/bpf/test_cgrp2_sock2.c index 3b5be2364975..a9277b118c33 100644 --- a/samples/bpf/test_cgrp2_sock2.c +++ b/samples/bpf/test_cgrp2_sock2.c @@ -51,7 +51,7 @@ int main(int argc, char **argv) if (argc > 3) filter_id = atoi(argv[3]); - if (filter_id > prog_cnt) { + if (filter_id >= prog_cnt) { printf("Invalid program id; program not found in file\n"); return EXIT_FAILURE; }