From: David Miller <davem@davemloft.net>
To: laoar.shao@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
shaoyafang@didichuxing.com, edumazet@google.com
Subject: Re: [PATCH net-next] tcp: remove redundant rcv_nxt update
Date: Sat, 14 Jul 2018 11:22:04 -0700 (PDT) [thread overview]
Message-ID: <20180714.112204.1831168896985469983.davem@davemloft.net> (raw)
In-Reply-To: <1531557390-12592-1-git-send-email-laoar.shao@gmail.com>
From: Yafang Shao <laoar.shao@gmail.com>
Date: Sat, 14 Jul 2018 16:36:29 +0800
> tcp_rcv_nxt_update() is already executed in tcp_data_queue().
> This line is redundant.
>
> See bellow,
> tcp_queue_rcv
> tcp_rcv_nxt_update(tcp_sk(sk), TCP_SKB_CB(skb)->end_seq);
> tcp_rcv_nxt_update(tp, TCP_SKB_CB(skb)->end_seq); <<<< redundant
>
> Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied.
prev parent reply other threads:[~2018-07-14 18:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-14 8:36 [PATCH net-next] tcp: remove redundant rcv_nxt update Yafang Shao
2018-07-14 18:22 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180714.112204.1831168896985469983.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shaoyafang@didichuxing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).