From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Chevallier Subject: Re: [PATCH net-next 4/5] net: mvpp2: debugfs: add entries for classifier flows Date: Sat, 14 Jul 2018 13:20:47 +0200 Message-ID: <20180714132047.43a03fab@bootlin.com> References: <20180713161344.19872-1-maxime.chevallier@bootlin.com> <20180713161344.19872-5-maxime.chevallier@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Antoine Tenart , thomas.petazzoni@bootlin.com, gregory.clement@bootlin.com, miquel.raynal@bootlin.com, nadavh@marvell.com, stefanc@marvell.com, ymarkman@marvell.com, mw@semihalf.com To: davem@davemloft.net Return-path: In-Reply-To: <20180713161344.19872-5-maxime.chevallier@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, 13 Jul 2018 18:13:43 +0200 Maxime Chevallier wrote: >+static int mvpp2_dbgfs_flow_id_show(struct seq_file *s, void *unused) >+{ >+ struct mvpp2_dbgfs_flow_entry *entry = s->private; >+ struct mvpp2_cls_flow *f; >+ >+ f = mvpp2_cls_flow_get(entry->flow); This won't compile with commit 9cee8c437543 ("net: mvpp2: mvpp2_cls_flow_get() can be static") I should have seen that missing static in the RSS series, now that it's fixed I'll send a V2 of that debugfs series, to make that function non static for the right reason this time. Thanks, Maxime