From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCHv2 net 0/2] multicast: init as INCLUDE when join SSM INCLUDE group Date: Mon, 16 Jul 2018 11:20:20 -0700 (PDT) Message-ID: <20180716.112020.1636634248436524943.davem@davemloft.net> References: <1528871551-17879-1-git-send-email-liuhangbin@gmail.com> <1531233687-28744-1-git-send-email-liuhangbin@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, sbrivio@redhat.com, pabeni@redhat.com, daniel@iogearbox.net, xiyou.wangcong@gmail.com, hideaki.yoshifuji@miraclelinux.com, fbl@redhat.com To: liuhangbin@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:57710 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727479AbeGPSs5 (ORCPT ); Mon, 16 Jul 2018 14:48:57 -0400 In-Reply-To: <1531233687-28744-1-git-send-email-liuhangbin@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Hangbin Liu Date: Tue, 10 Jul 2018 22:41:25 +0800 > Based on RFC3376 5.1 and RFC3810 6.1, we should init as INCLUDE when join SSM > INCLUDE group. In my first version I only clear the group change record. But > this is not enough as when a new group join, it will init as EXCLUDE and > trigger an filter mode change in ip/ip6_mc_add_src(), which will clear all > source addresses' sf_crcount. This will prevent early joined address sending > state change records if multi source addresses joined at the same time. > > In this v2 patchset, I fixed it by directly initializing the mode to INCLUDE > for SSM JOIN_SOURCE_GROUP. I also split the original patch into two separated > patches for IPv4 and IPv6. > > Test: test by myself and customer. Series applied, thanks!