From: David Miller <davem@davemloft.net>
To: davejwatson@fb.com
Cc: borisp@mellanox.com, netdev@vger.kernel.org,
aviadye@mellanox.com, daniel@iogearbox.net, doronrk@fb.com,
vakul.garg@nxp.com
Subject: Re: [PATCH net] tls: Stricter error checking in zerocopy sendmsg path
Date: Mon, 16 Jul 2018 13:32:37 -0700 (PDT) [thread overview]
Message-ID: <20180716.133237.2093552528129465739.davem@davemloft.net> (raw)
In-Reply-To: <20180712150343.GA19138@macbook-pro-6.local.dhcp.thefacebook.com>
From: Dave Watson <davejwatson@fb.com>
Date: Thu, 12 Jul 2018 08:03:43 -0700
> In the zerocopy sendmsg() path, there are error checks to revert
> the zerocopy if we get any error code. syzkaller has discovered
> that tls_push_record can return -ECONNRESET, which is fatal, and
> happens after the point at which it is safe to revert the iter,
> as we've already passed the memory to do_tcp_sendpages.
>
> Previously this code could return -ENOMEM and we would want to
> revert the iter, but AFAIK this no longer returns ENOMEM after
> a447da7d004 ("tls: fix waitall behavior in tls_sw_recvmsg"),
> so we fail for all error codes.
>
> Reported-by: syzbot+c226690f7b3126c5ee04@syzkaller.appspotmail.com
> Reported-by: syzbot+709f2810a6a05f11d4d3@syzkaller.appspotmail.com
> Signed-off-by: Dave Watson <davejwatson@fb.com>
> Fixes: 3c4d7559159b ("tls: kernel TLS support")
Applied and queued up for -stable, thanks Dave.
prev parent reply other threads:[~2018-07-16 21:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 15:03 [PATCH net] tls: Stricter error checking in zerocopy sendmsg path Dave Watson
2018-07-16 20:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716.133237.2093552528129465739.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=daniel@iogearbox.net \
--cc=davejwatson@fb.com \
--cc=doronrk@fb.com \
--cc=netdev@vger.kernel.org \
--cc=vakul.garg@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).