From: David Miller <davem@davemloft.net>
To: lirongqing@baidu.com
Cc: netdev@vger.kernel.org, edumazet@google.com, sbrivio@redhat.com
Subject: Re: [PATCH][net-next][v2] net: convert gro_count to bitmask
Date: Mon, 16 Jul 2018 13:41:31 -0700 (PDT) [thread overview]
Message-ID: <20180716.134131.1554894339720285923.davem@davemloft.net> (raw)
In-Reply-To: <1531464096-11319-1-git-send-email-lirongqing@baidu.com>
From: Li RongQing <lirongqing@baidu.com>
Date: Fri, 13 Jul 2018 14:41:36 +0800
> gro_hash size is 192 bytes, and uses 3 cache lines, if there is few
> flows, gro_hash may be not fully used, so it is unnecessary to iterate
> all gro_hash in napi_gro_flush(), to occupy unnecessary cacheline.
>
> convert gro_count to a bitmask, and rename it as gro_bitmask, each bit
> represents a element of gro_hash, only flush a gro_hash element if the
> related bit is set, to speed up napi_gro_flush().
>
> and update gro_bitmask only if it will be changed, to reduce cache
> update
>
> Suggested-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
> Cc: Stefano Brivio <sbrivio@redhat.com>
> ---
> netperf shows no difference, maybe because my testing machine has large
> cache
Applied.
next prev parent reply other threads:[~2018-07-16 21:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 6:41 [PATCH][net-next][v2] net: convert gro_count to bitmask Li RongQing
2018-07-16 20:41 ` David Miller [this message]
2018-07-16 23:40 ` Eric Dumazet
2018-07-17 0:02 ` David Miller
2018-07-17 1:04 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716.134131.1554894339720285923.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=lirongqing@baidu.com \
--cc=netdev@vger.kernel.org \
--cc=sbrivio@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).