From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] net: mscc: simplify retrieving the tag type from the frame header Date: Mon, 16 Jul 2018 13:44:11 -0700 (PDT) Message-ID: <20180716.134411.1283470643018673209.davem@davemloft.net> References: <20180713145757.3574-1-antoine.tenart@bootlin.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: f.fainelli@gmail.com, andrew@lunn.ch, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, alexandre.belloni@bootlin.com, quentin.schulz@bootlin.com, allan.nielsen@microsemi.com To: antoine.tenart@bootlin.com Return-path: In-Reply-To: <20180713145757.3574-1-antoine.tenart@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Antoine Tenart Date: Fri, 13 Jul 2018 16:57:57 +0200 > The tag type in the frame extraction header is only a bit wide. There's > no need to use GENMASK when retrieving the information. This patch > simplify the code by dropping GENMASK and using BIT instead. > > Signed-off-by: Antoine Tenart Applied.