From: David Miller <davem@davemloft.net>
To: stefan.wahren@i2se.com
Cc: woojung.huh@microchip.com, UNGLinuxDriver@microchip.com,
gregkh@linuxfoundation.org, dave.stevenson@raspberrypi.org,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
stable@vger.kernel.org, bos@je-eigen-domein.nl
Subject: Re: [PATCH] net: lan78xx: Fix race in tx pending skb size calculation
Date: Mon, 16 Jul 2018 14:13:20 -0700 (PDT) [thread overview]
Message-ID: <20180716.141320.1898046446934093342.davem@davemloft.net> (raw)
In-Reply-To: <1531684400-15778-1-git-send-email-stefan.wahren@i2se.com>
From: Stefan Wahren <stefan.wahren@i2se.com>
Date: Sun, 15 Jul 2018 21:53:20 +0200
> The skb size calculation in lan78xx_tx_bh is in race with the start_xmit,
> which could lead to rare kernel oopses. So protect the whole skb walk with
> a spin lock. As a benefit we can unlink the skb directly.
>
> This patch was tested on Raspberry Pi 3B+
>
> Link: https://github.com/raspberrypi/linux/issues/2608
> Fixes: 55d7de9de6c3 ("Microchip's LAN7800 family USB 2/3 to 10/100/1000 Ethernet")
> Cc: stable <stable@vger.kernel.org>
> Signed-off-by: Floris Bos <bos@je-eigen-domein.nl>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2018-07-16 21:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-15 19:53 [PATCH] net: lan78xx: Fix race in tx pending skb size calculation Stefan Wahren
2018-07-16 21:13 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716.141320.1898046446934093342.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=UNGLinuxDriver@microchip.com \
--cc=bos@je-eigen-domein.nl \
--cc=dave.stevenson@raspberrypi.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=stefan.wahren@i2se.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox