From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] ibmvnic: Fix error recovery on login failure Date: Mon, 16 Jul 2018 14:40:08 -0700 (PDT) Message-ID: <20180716.144008.687460894526079524.davem@davemloft.net> References: <20180716152930.22255-1-jallen@linux.ibm.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: tlfalcon@linux.vnet.ibm.com, netdev@vger.kernel.org, jallen@linux.vnet.ibm.com To: jallen@linux.ibm.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:60674 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728442AbeGPWJ3 (ORCPT ); Mon, 16 Jul 2018 18:09:29 -0400 In-Reply-To: <20180716152930.22255-1-jallen@linux.ibm.com> Sender: netdev-owner@vger.kernel.org List-ID: From: John Allen Date: Mon, 16 Jul 2018 10:29:30 -0500 > Testing has uncovered a failure case that is not handled properly. In the > event that a login fails and we are not able to recover on the spot, we > return 0 from do_reset, preventing any error recovery code from being > triggered. Additionally, the state is set to "probed" meaning that when we > are able to trigger the error recovery, the driver always comes up in the > probed state. To handle the case properly, we need to return a failure code > here and set the adapter state to the state that we entered the reset in > indicating the state that we would like to come out of the recovery reset > in. > > Signed-off-by: John Allen Applied, thanks.