From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] sch_cake: Fix tin order when set through skb->priority Date: Mon, 16 Jul 2018 14:48:16 -0700 (PDT) Message-ID: <20180716.144816.922973459930323763.davem@davemloft.net> References: <20180716144509.31121-1-toke@toke.dk> Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net To: toke@toke.dk Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:60806 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728413AbeGPWRg (ORCPT ); Mon, 16 Jul 2018 18:17:36 -0400 In-Reply-To: <20180716144509.31121-1-toke@toke.dk> Sender: netdev-owner@vger.kernel.org List-ID: From: Toke Høiland-Jørgensen Date: Mon, 16 Jul 2018 16:45:09 +0200 > In diffserv mode, CAKE stores tins in a different order internally than > the logical order exposed to userspace. The order remapping was missing > in the handling of 'tc filter' priority mappings through skb->priority, > resulting in bulk and best effort mappings being reversed relative to > how they are displayed. > > Fix this by adding the missing mapping when reading skb->priority. > > Fixes: 83f8fd69af4f ("sch_cake: Add DiffServ handling") > Signed-off-by: Toke Høiland-Jørgensen Applied, thanks.