From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [Cake] [PATCH iproute2-next v10] Add support for CAKE qdisc Date: Mon, 16 Jul 2018 10:06:46 -0700 Message-ID: <20180716100646.788fc9c0@xeon-e3> References: <20180716163926.4826-1-toke@toke.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= Return-path: Received: from mail-pl0-f68.google.com ([209.85.160.68]:44870 "EHLO mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727792AbeGPRfG (ORCPT ); Mon, 16 Jul 2018 13:35:06 -0400 Received: by mail-pl0-f68.google.com with SMTP id m16-v6so15527982pls.11 for ; Mon, 16 Jul 2018 10:06:49 -0700 (PDT) In-Reply-To: <20180716163926.4826-1-toke@toke.dk> Sender: netdev-owner@vger.kernel.org List-ID: On Mon, 16 Jul 2018 18:39:26 +0200 Toke H=C3=B8iland-J=C3=B8rgensen wrote: > +#define PRINT_TSTAT(name, attr, fmts, val) do { \ > + if (GET_TSTAT(0, attr)) { \ > + fprintf(f, name); \ > + for (i =3D 0; i < num_tins; i++) \ > + fprintf(f, " %12" fmts, val); \ > + fprintf(f, "\n"); \ > + } \ > + } while (0) Couldn't this be a function?