From: Stephen Hemminger <stephen@networkplumber.org>
To: "Mahesh Bandewar (महेश बंडेवार)" <maheshb@google.com>
Cc: Mahesh Bandewar <mahesh@bandewar.net>,
Jay Vosburgh <j.vosburgh@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>,
Veaceslav Falico <vfalico@gmail.com>,
David Miller <davem@davemloft.net>,
Netdev <netdev@vger.kernel.org>, Michal Soltys <soltys@ziu.info>
Subject: Re: [PATCH next] bonding: pass link-local packets to bonding master also.
Date: Mon, 16 Jul 2018 17:43:49 -0700 [thread overview]
Message-ID: <20180716174349.0489c091@xeon-e3> (raw)
In-Reply-To: <CAF2d9jjTh2ksyfe_n8yzvBB6ux8CPXWbr+m7XzKYR3iwkOcE8Q@mail.gmail.com>
On Mon, 16 Jul 2018 16:57:22 -0700
Mahesh Bandewar (महेश बंडेवार) <maheshb@google.com> wrote:
> On Mon, Jul 16, 2018 at 4:33 PM, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> > On Sun, 15 Jul 2018 18:12:46 -0700
> > Mahesh Bandewar <mahesh@bandewar.net> wrote:
> >
> >> From: Mahesh Bandewar <maheshb@google.com>
> >>
> >> Commit b89f04c61efe ("bonding: deliver link-local packets with
> >> skb->dev set to link that packets arrived on") changed the behavior
> >> of how link-local-multicast packets are processed. The change in
> >> the behavior broke some legacy use cases where these packets are
> >> expected to arrive on bonding master device also.
> >>
> >> This patch passes the packet to the stack with the link it arrived
> >> on as well as passes to the bonding-master device to preserve the
> >> legacy use case.
> >>
> >> Reported-by: Michal Soltys <soltys@ziu.info>
> >> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
> >
> > Thanks for fixing this.
> >
> > Why not add a Fixes: tag instead of just talking about the commit?
> > That helps the stable maintainers know which versions of the kernel
> > need the patch.
> Well, I thought about it. It's definitely 'related' but not sure it
> 'fixes' in true sense. It definitely fixes the broken legacy case
> though. Is that sufficient to add 'fixes' tag?
The previous commit caused a regression. your change fixes the regression
next prev parent reply other threads:[~2018-07-17 1:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 1:12 [PATCH next] bonding: pass link-local packets to bonding master also Mahesh Bandewar
2018-07-16 21:24 ` Jay Vosburgh
2018-07-16 23:53 ` Mahesh Bandewar (महेश बंडेवार)
2018-07-17 9:32 ` Michal Soltys
2018-07-17 22:17 ` Michal Soltys
2018-07-16 23:33 ` Stephen Hemminger
2018-07-16 23:57 ` Mahesh Bandewar (महेश बंडेवार)
2018-07-17 0:43 ` Stephen Hemminger [this message]
2018-07-17 9:55 ` Michal Soltys
2018-11-30 21:32 ` [next] " Vincent Bernat
2018-12-09 8:30 ` Vincent Bernat
2018-12-19 22:57 ` Michal Soltys
2018-12-20 5:55 ` Vincent Bernat
2018-12-23 13:06 ` Michal Soltys
2018-12-23 13:16 ` Vincent Bernat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716174349.0489c091@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=j.vosburgh@gmail.com \
--cc=mahesh@bandewar.net \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
--cc=soltys@ziu.info \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).