From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gustavo A. R. Silva" Subject: [PATCH] rtnetlink: fix uninitialized variable Date: Tue, 17 Jul 2018 08:43:14 -0500 Message-ID: <20180717134314.GA31127@embeddedor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" To: Jakub Kicinski , "David S. Miller" Return-path: Received: from gateway22.websitewelcome.com ([192.185.46.225]:23203 "EHLO gateway22.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731497AbeGQOQA (ORCPT ); Tue, 17 Jul 2018 10:16:00 -0400 Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 732104127 for ; Tue, 17 Jul 2018 08:43:16 -0500 (CDT) Content-Disposition: inline Sender: netdev-owner@vger.kernel.org List-ID: Currently, there are execution paths in which variable err is returned without being properly initialized previously: 1417 if (rtnl_xdp_report_one(skb, dev, &prog_id, &mode, XDP_ATTACHED_SKB, 1418 IFLA_XDP_SKB_PROG_ID, rtnl_xdp_prog_skb)) 1419 goto err_cancel; 1420 if (rtnl_xdp_report_one(skb, dev, &prog_id, &mode, XDP_ATTACHED_DRV, 1421 IFLA_XDP_DRV_PROG_ID, rtnl_xdp_prog_drv)) 1422 goto err_cancel; 1423 if (rtnl_xdp_report_one(skb, dev, &prog_id, &mode, XDP_ATTACHED_HW, 1424 IFLA_XDP_HW_PROG_ID, rtnl_xdp_prog_hw)) 1425 goto err_cancel; Fix this by initializing variable err to -EMSGSIZE. Addresses-Coverity-ID: 1471831 ("Uninitialized scalar variable") Fixes: a25717d2b604 ("xdp: support simultaneous driver and hw XDP attachment") Signed-off-by: Gustavo A. R. Silva --- net/core/rtnetlink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index e03258e..648c984 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -1405,12 +1405,12 @@ static int rtnl_xdp_fill(struct sk_buff *skb, struct net_device *dev) { struct nlattr *xdp; u32 prog_id; - int err; + int err = -EMSGSIZE; u8 mode; xdp = nla_nest_start(skb, IFLA_XDP); if (!xdp) - return -EMSGSIZE; + return err; prog_id = 0; mode = XDP_ATTACHED_NONE; -- 2.7.4