From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH] ARM: dts: sunxi: Remove unused address-cells/size-cells of dwmac-sun8i Date: Tue, 17 Jul 2018 17:19:53 +0200 Message-ID: <20180717151953.oab5tsurldmz4tjn@flea> References: <1531655749-14063-1-git-send-email-clabbe@baylibre.com> Reply-To: maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rpucpdbcayeuqohf" Cc: catalin.marinas-5wv7dgnIgG8@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org To: Corentin Labbe Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <1531655749-14063-1-git-send-email-clabbe-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , List-Id: netdev.vger.kernel.org --rpucpdbcayeuqohf Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline On Sun, Jul 15, 2018 at 11:55:49AM +0000, Corentin Labbe wrote: > address-cells/size-cells is unnecessary for dwmac-sun8i node. > It was in early days, but since a mdio node is used, it could be > removed. > > This patch fix the following DT warning: > Warning (avoid_unnecessary_addr_size): /soc/ethernet@1c50000: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property > > Signed-off-by: Corentin Labbe > --- > Documentation/devicetree/bindings/net/dwmac-sun8i.txt | 8 -------- > arch/arm/boot/dts/sun8i-a83t.dtsi | 2 -- > arch/arm/boot/dts/sun8i-r40.dtsi | 2 -- > arch/arm/boot/dts/sunxi-h3-h5.dtsi | 2 -- > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 2 -- Just saw this, and dropped the patch. Please provide separate patches for the h3-h5 DTSI, the arm64 and arm patches. And ideally for the binding. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com --rpucpdbcayeuqohf--