netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Wunderlich <sw@simonwunderlich.de>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
	Sven Eckelmann <sven@narfation.org>,
	Simon Wunderlich <sw@simonwunderlich.de>
Subject: [PATCH 7/7] batman-adv: Convert batadv_dat_addr_t to proper type
Date: Tue, 17 Jul 2018 17:26:49 +0200	[thread overview]
Message-ID: <20180717152649.32282-8-sw@simonwunderlich.de> (raw)
In-Reply-To: <20180717152649.32282-1-sw@simonwunderlich.de>

From: Sven Eckelmann <sven@narfation.org>

The #define for batadv_dat_addr_t is doing nothing else than giving u16 a
new typename. But C already has the special keyword "typedef" which is also
better supported by kernel-doc.

Signed-off-by: Sven Eckelmann <sven@narfation.org>
Acked-by: Antonio Quartulli <a@unstable.cc>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
---
 net/batman-adv/types.h | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/net/batman-adv/types.h b/net/batman-adv/types.h
index 360357f83f20..343d304851a5 100644
--- a/net/batman-adv/types.h
+++ b/net/batman-adv/types.h
@@ -43,12 +43,13 @@ struct seq_file;
 #ifdef CONFIG_BATMAN_ADV_DAT
 
 /**
- * batadv_dat_addr_t - it is the type used for all DHT addresses. If it is
- *  changed, BATADV_DAT_ADDR_MAX is changed as well.
+ * typedef batadv_dat_addr_t - type used for all DHT addresses
+ *
+ * If it is changed, BATADV_DAT_ADDR_MAX is changed as well.
  *
  * *Please be careful: batadv_dat_addr_t must be UNSIGNED*
  */
-#define batadv_dat_addr_t u16
+typedef u16 batadv_dat_addr_t;
 
 #endif /* CONFIG_BATMAN_ADV_DAT */
 
-- 
2.11.0

  parent reply	other threads:[~2018-07-17 16:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-17 15:26 [PATCH 0/7] pull request for net-next: batman-adv 2018-07-17 Simon Wunderlich
2018-07-17 15:26 ` [PATCH 1/7] batman-adv: Drop "experimental" from BATMAN_V Kconfig Simon Wunderlich
2018-07-17 15:26 ` [PATCH 2/7] batman-adv: enable DAT by default at compile time Simon Wunderlich
2018-07-17 15:26 ` [PATCH 3/7] batman-adv: Remove "default n" in Kconfig Simon Wunderlich
2018-07-17 15:26 ` [PATCH 4/7] batman-adv: fix checkpatch warning about misspelled "cache" Simon Wunderlich
2018-07-17 15:26 ` [PATCH 5/7] batman-adv: Unify include guards style Simon Wunderlich
2018-07-17 15:26 ` [PATCH 6/7] batman-adv: Join batadv_purge_orig_ref and _batadv_purge_orig Simon Wunderlich
2018-07-17 15:26 ` Simon Wunderlich [this message]
2018-07-18  5:47 ` [PATCH 0/7] pull request for net-next: batman-adv 2018-07-17 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180717152649.32282-8-sw@simonwunderlich.de \
    --to=sw@simonwunderlich.de \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=sven@narfation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).