From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: [PATCH net-next 3/7] net: systemport: Do not re-configure upon WoL interrupt Date: Tue, 17 Jul 2018 08:36:41 -0700 Message-ID: <20180717153645.7500-5-f.fainelli@gmail.com> References: <20180717153645.7500-1-f.fainelli@gmail.com> Cc: Florian Fainelli , linville@tuxdriver.com, davem@davemloft.net, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com To: netdev@vger.kernel.org Return-path: Received: from mail-wm0-f67.google.com ([74.125.82.67]:51175 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731455AbeGQQKf (ORCPT ); Tue, 17 Jul 2018 12:10:35 -0400 Received: by mail-wm0-f67.google.com with SMTP id v25-v6so1977942wmc.0 for ; Tue, 17 Jul 2018 08:37:22 -0700 (PDT) In-Reply-To: <20180717153645.7500-1-f.fainelli@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: We already properly resume from Wake-on-LAN whether such a condition occured or not, no need to process the WoL interrupt for functional changes since that could race with other settings. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/bcmsysport.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c index eb890c4b3b2d..f152826f3d06 100644 --- a/drivers/net/ethernet/broadcom/bcmsysport.c +++ b/drivers/net/ethernet/broadcom/bcmsysport.c @@ -1102,10 +1102,8 @@ static irqreturn_t bcm_sysport_rx_isr(int irq, void *dev_id) if (priv->irq0_stat & INTRL2_0_TX_RING_FULL) bcm_sysport_tx_reclaim_all(priv); - if (priv->irq0_stat & INTRL2_0_MPD) { + if (priv->irq0_stat & INTRL2_0_MPD) netdev_info(priv->netdev, "Wake-on-LAN interrupt!\n"); - bcm_sysport_resume_from_wol(priv); - } if (!priv->is_lite) goto out; -- 2.14.1