From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net-next 0/7] net: Support Wake-on-LAN using filters Date: Tue, 17 Jul 2018 18:51:49 +0200 Message-ID: <20180717165149.GJ968@lunn.ch> References: <20180717153645.7500-1-f.fainelli@gmail.com> <20180717154702.GD968@lunn.ch> <7e48b9b3-3e90-e56e-46af-b1108dc63292@gmail.com> <20180717162136.GH968@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, linville@tuxdriver.com, davem@davemloft.net, vivien.didelot@savoirfairelinux.com To: Florian Fainelli Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:37177 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729648AbeGQRZX (ORCPT ); Tue, 17 Jul 2018 13:25:23 -0400 Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Jul 17, 2018 at 09:28:52AM -0700, Florian Fainelli wrote: > > > On 07/17/2018 09:21 AM, Andrew Lunn wrote: > >>>> ethtool -s gphy wol f filters 0x2 > >>> > >>> What does this 0x2 represent? > >> > >> 0x2 = bit 1 is set, which corresponds to the filter ID that was returned > >> from the previous ethtool::rxnfc command invocation. If ethtool > >> --config-nfc returned 3, then we would have used filters 0x8, etc. > > > > It would be a simpler for the user if you could pass the filter IDs as > > a list, and let ethtool do the shift and OR. > > Sure, I can definitively add that, is a comma separator okay with you > for that? E.g: > > ethtool -s gphy wol f filters 0,1,2,3,4,5,6,7 Hi Florian That looks good. But maybe check the man page for ethtool and see if there is an established convention. Andrew